Repository navigation
Fix #233: Remove self._number_of_bots, pass number_of_bots to _create_players() - #403
Closed
ahmedmajid22 wants to merge 2 commits into
Closed
ahmedmajid22 wants to merge 2 commits into
ahmedmajid22 wants to merge 2 commits into
Conversation
Collaborator
|
After analysis, the new code solving this issue is more complex. We did not know this beforehand. Now we have learned that the whole idea of removing self._number_of_bots is flawed. Hence the issue should be closed with "wontfix" and this pull request rejected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #233
Removes the unused self._number_of_bots instance variable from init and passes number_of_bots directly as a parameter to _create_players(). In reset(), the bot count is derived from the observation space shape since number_of_bots is not available there. Adds cast to the typing import as required.